Use CGO_ENBABLED=0 for build #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we want to change this now? |
Updated the description with some context. |
MrAlias
reviewed
Oct 30, 2024
Do we want to change to |
Sure. I think that image is there because we used to have some glibc requirements in the past. |
I think it would be cleaner as a separate PR. |
pellared
approved these changes
Oct 31, 2024
MrAlias
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have a dependency that required CGO_ENABLED - this was removed in #624.
According to #1215, it seems we are building with CGO_ENABLED (even though we don't have to).